dictionary from encounters subresource (#332)#335
Closed
jrubinator wants to merge 3 commits intoPokeAPI:masterfrom
Closed
dictionary from encounters subresource (#332)#335jrubinator wants to merge 3 commits intoPokeAPI:masterfrom
jrubinator wants to merge 3 commits intoPokeAPI:masterfrom
Conversation
This makes it consistent with the every other resource Unfortunately this isn't tested or testable in the current framework, as distinct() is not supported by the sqlite3 backend
AgustinRamiroDiaz
approved these changes
Mar 8, 2021
TheSatanicFlame
approved these changes
Nov 8, 2023
|
The encounters resource, as it is, is really weird. I'd love to see this PR merged! One note about this; because it also changes the endpoint, this should be able to be updated so that it simply adds a new endpoint that operates as expected but leaves the old endpoint in the old format for compatibility. |
Author
|
That's probably wise. Commenting to say it's been a (very) long time since I worked on this, and I'm not interested in pushing for its merge at this point, but I would be thrilled if someone else got it to the finish line! |
Member
|
Closing as this is old and I want to tidy things up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it consistent with the every other resource
Unfortunately this isn't tested or testable in the current framework,
as distinct() is not supported by the sqlite3 backend